Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ensure_packages() to be more polite about apt-transport-https #154

Merged
merged 1 commit into from
Jan 20, 2016
Merged

Use ensure_packages() to be more polite about apt-transport-https #154

merged 1 commit into from
Jan 20, 2016

Conversation

rtyler
Copy link
Contributor

@rtyler rtyler commented Dec 11, 2015

This will prevent this module from getting up in arms with any other package
resource trying to ensure that apt-transport-https is installed

Use ensure_packages() instead of a hard package[] resource to be more…
c8ce536 
… polite

This will prevent this module from getting up in arms with any other package
resource trying to ensure that apt-transport-https is installed
@ojongerius
Copy link
Contributor

@olivielpeau could we please get this reviewed and merged?

@ColinHebert
Copy link
Contributor

@truthbk Hey, would it be possible to merge this PR?

Currently the puppet-datadog-agent module conflicts with other modules that are installing apt-transport-https themselves making this module unusable. Using ensure_packages() is the recommended behaviour for puppet modules to install related packages.

@ColinHebert
Copy link
Contributor

@talwai Would it be possible to get this merged and released?

@irabinovitch
Copy link

@ColinHebert @ojongerius We're currently working on a new release of the puppet module which will include a number of pending PRs. Thank you for your patience while we work through testing on our end.

@talwai talwai added this to the 1.6.0 milestone Jan 11, 2016
@talwai talwai self-assigned this Jan 11, 2016
@ojongerius
Copy link
Contributor

Thanks @irabinovitch.

@talwai
Copy link
Contributor

talwai commented Jan 20, 2016

@rtyler Thanks for the fix, much appreciated!

talwai added a commit that referenced this pull request Jan 20, 2016
@talwai
Merge pull request #154 from jenkins-infra/polite-apt-management
974e60c 
Use ensure_packages() to be more polite about apt-transport-https
@talwai talwai merged commit 974e60c into DataDog:master Jan 20, 2016
@ojongerius
Copy link
Contributor

Thanks!

For the record, I do think a bug fix like this could have gone out to 1.5.

cegeka-jenkins pushed a commit to cegeka/puppet-datadog_agent that referenced this pull request Jan 31, 2018
@talwai
Merge pull request DataDog#154 from jenkins-infra/polite-apt-management
8a9b0a1 
Use ensure_packages() to be more polite about apt-transport-https
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@talwai talwai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rtyler @ojongerius @ColinHebert @irabinovitch @talwai