Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crashtracker) : Fix crash when sending crashinfo #756

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(crashtracker) : Fix crash when sending crashinfo #756

wants to merge 2 commits into from
+41 −0

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Nov 22, 2024 •
edited
Loading

What does this PR do?

When calling ddog_crasht_CrashInfo_upload_to_endpoint, if the ProcInfo is not set, the process crashes with panic

 thread '<unnamed>' panicked at crashtracker/src/rfc5_crash_info/mod.rs:74:41:

Motivation

Fix a bug and missing API.

How to test the change?

The crashinfo example runs in CI.
Added calls to ddog_crasht_CrashInfo_set_procinfo to fix the crash

@pr-commenter
Copy link

pr-commenter bot commented Nov 22, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-22 22:15:42

Comparing candidate commit 9b34032 in PR branch gleocadie/fix-bug-in-crashtracker with baseline commit 191a68a in branch main.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:concentrator/add_spans_to_concentrator

  • 🟥 execution_time [+871.781µs; +877.905µs] or [+9.687%; +9.755%]

scenario:tags/replace_trace_tags

  • 🟩 execution_time [-274.826ns; -266.881ns] or [-9.250%; -8.983%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 38.444µs 38.973µs ± 0.876µs 38.563µs ± 0.057µs 38.696µs 40.846µs 40.902µs 41.787µs 8.36% 1.704 1.040 2.24% 0.062µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [38.852µs; 39.095µs] or [-0.312%; +0.312%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 68.812µs 68.979µs ± 0.139µs 68.956µs ± 0.032µs 68.990µs 69.098µs 69.284µs 70.615µs 2.41% 8.515 94.369 0.20% 0.010µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [68.960µs; 68.998µs] or [-0.028%; +0.028%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 60.719ms 61.039ms ± 0.172ms 60.983ms ± 0.059ms 61.083ms 61.426ms 61.471ms 61.811ms 1.36% 1.549 2.449 0.28% 0.012ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [61.015ms; 61.063ms] or [-0.039%; +0.039%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 300.517µs 305.418µs ± 1.897µs 305.242µs ± 1.345µs 306.751µs 308.950µs 309.351µs 310.424µs 1.70% 0.253 -0.419 0.62% 0.134µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3221396.948op/s 3274330.406op/s ± 20305.925op/s 3276088.748op/s ± 14431.535op/s 3287571.355op/s 3304615.745op/s 3311570.209op/s 3327598.771op/s 1.57% -0.225 -0.431 0.62% 1435.846op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 28.136µs 28.342µs ± 0.087µs 28.342µs ± 0.047µs 28.386µs 28.470µs 28.569µs 28.927µs 2.06% 1.550 9.308 0.31% 0.006µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 34569652.698op/s 35283643.249op/s ± 108007.101op/s 35282888.190op/s ± 58507.530op/s 35352571.370op/s 35447920.534op/s 35493831.724op/s 35541812.721op/s 0.73% -1.469 8.724 0.31% 7637.255op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.591µs 16.688µs ± 0.078µs 16.687µs ± 0.040µs 16.723µs 16.772µs 16.815µs 17.500µs 4.87% 5.753 57.868 0.46% 0.005µs 1 200
normalization/normalize_name/normalize_name/good throughput 57143219.957op/s 59925404.412op/s ± 271843.371op/s 59925646.468op/s ± 144519.950op/s 60082220.212op/s 60232708.339op/s 60258443.520op/s 60275101.746op/s 0.58% -5.391 52.925 0.45% 19222.229op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [305.155µs; 305.681µs] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3271516.200op/s; 3277144.612op/s] or [-0.086%; +0.086%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [28.330µs; 28.354µs] or [-0.043%; +0.043%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35268674.504op/s; 35298611.995op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.677µs; 16.699µs] or [-0.064%; +0.064%] None None None
normalization/normalize_name/normalize_name/good throughput [59887729.535op/s; 59963079.289op/s] or [-0.063%; +0.063%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.640µs 2.700µs ± 0.021µs 2.701µs ± 0.008µs 2.710µs 2.737µs 2.740µs 2.742µs 1.54% -0.574 0.926 0.79% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.697µs; 2.703µs] or [-0.110%; +0.110%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.400µs 3.274µs ± 1.458µs 3.116µs ± 0.022µs 3.137µs 3.191µs 14.338µs 15.363µs 392.97% 7.603 57.813 44.43% 0.103µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.072µs; 3.476µs] or [-6.173%; +6.173%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 299.365ns 312.225ns ± 13.732ns 305.757ns ± 4.680ns 315.778ns 340.740ns 351.911ns 353.376ns 15.57% 1.372 0.782 4.39% 0.971ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [310.322ns; 314.128ns] or [-0.610%; +0.610%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.836ms 9.875ms ± 0.017ms 9.874ms ± 0.009ms 9.883ms 9.895ms 9.948ms 9.966ms 0.93% 1.746 7.524 0.17% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.872ms; 9.877ms] or [-0.024%; +0.024%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.436µs 24.411µs ± 13.885µs 18.630µs ± 0.105µs 18.883µs 46.395µs 48.299µs 156.847µs 741.89% 5.185 41.498 56.74% 0.982µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [22.487µs; 26.335µs] or [-7.883%; +7.883%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 619.844µs 621.241µs ± 0.657µs 621.245µs ± 0.242µs 621.478µs 621.830µs 622.204µs 628.233µs 1.12% 5.932 62.497 0.11% 0.046µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1591765.774op/s 1609683.259op/s ± 1693.025op/s 1609670.471op/s ± 625.999op/s 1610310.064op/s 1611816.498op/s 1613057.705op/s 1613310.023op/s 0.23% -5.840 61.266 0.10% 119.715op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 466.499µs 467.208µs ± 0.420µs 467.170µs ± 0.152µs 467.311µs 467.609µs 467.927µs 471.998µs 1.03% 7.474 82.587 0.09% 0.030µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2118652.336op/s 2140377.493op/s ± 1913.030op/s 2140550.579op/s ± 698.615op/s 2141250.762op/s 2142127.970op/s 2143191.487op/s 2143629.252op/s 0.14% -7.397 81.423 0.09% 135.272op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 190.697µs 191.117µs ± 0.153µs 191.117µs ± 0.105µs 191.221µs 191.355µs 191.462µs 191.686µs 0.30% 0.035 0.407 0.08% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5216860.197op/s 5232401.087op/s ± 4179.487op/s 5232387.081op/s ± 2884.855op/s 5235296.896op/s 5238729.720op/s 5242085.900op/s 5243933.676op/s 0.22% -0.029 0.401 0.08% 295.534op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 47.026µs 47.361µs ± 0.143µs 47.364µs ± 0.101µs 47.468µs 47.588µs 47.654µs 47.695µs 0.70% -0.140 -0.464 0.30% 0.010µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 20966357.118op/s 21114512.376op/s ± 63816.306op/s 21112885.478op/s ± 44905.972op/s 21157064.985op/s 21228025.922op/s 21260190.362op/s 21265042.397op/s 0.72% 0.154 -0.460 0.30% 4512.494op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 51.053µs 51.433µs ± 0.210µs 51.510µs ± 0.121µs 51.573µs 51.671µs 51.755µs 52.829µs 2.56% 1.209 7.937 0.41% 0.015µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 18929091.174op/s 19443123.370op/s ± 78870.743op/s 19413562.500op/s ± 45585.696op/s 19520852.549op/s 19548321.602op/s 19569922.394op/s 19587679.350op/s 0.90% -1.110 7.144 0.40% 5577.004op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [621.150µs; 621.332µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1609448.622op/s; 1609917.896op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [467.149µs; 467.266µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2140112.366op/s; 2140642.621op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [191.096µs; 191.138µs] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5231821.850op/s; 5232980.324op/s] or [-0.011%; +0.011%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [47.341µs; 47.381µs] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21105668.050op/s; 21123356.702op/s] or [-0.042%; +0.042%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [51.404µs; 51.462µs] or [-0.056%; +0.056%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19432192.643op/s; 19454054.096op/s] or [-0.056%; +0.056%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.623µs 4.633µs ± 0.004µs 4.633µs ± 0.002µs 4.636µs 4.639µs 4.642µs 4.663µs 0.63% 1.778 12.632 0.09% 0.000µs 1 200
credit_card/is_card_number/ throughput 214467358.048op/s 215820860.168op/s ± 187854.900op/s 215828798.109op/s ± 101745.270op/s 215926942.285op/s 216101051.783op/s 216228604.114op/s 216299223.477op/s 0.22% -1.748 12.390 0.09% 13283.347op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 90.789µs 91.733µs ± 0.559µs 91.695µs ± 0.257µs 91.945µs 92.466µs 92.796µs 96.987µs 5.77% 4.279 37.409 0.61% 0.040µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10310636.030op/s 10901554.646op/s ± 64792.333op/s 10905727.619op/s ± 30519.544op/s 10937836.176op/s 10980586.378op/s 11001343.407op/s 11014511.619op/s 1.00% -3.912 32.957 0.59% 4581.510op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 83.768µs 84.059µs ± 0.363µs 84.009µs ± 0.046µs 84.061µs 84.270µs 84.399µs 88.837µs 5.75% 11.641 149.334 0.43% 0.026µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11256544.404op/s 11896685.140op/s ± 48923.465op/s 11903543.685op/s ± 6448.846op/s 11909446.573op/s 11919919.437op/s 11925555.012op/s 11937665.723op/s 0.29% -11.436 145.506 0.41% 3459.411op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.622µs 4.633µs ± 0.006µs 4.633µs ± 0.002µs 4.634µs 4.638µs 4.641µs 4.702µs 1.50% 7.644 85.365 0.13% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 212677489.413op/s 215843908.204op/s ± 277023.679op/s 215865850.027op/s ± 90023.420op/s 215953367.486op/s 216120318.482op/s 216149349.204op/s 216350224.818op/s 0.22% -7.532 83.674 0.13% 19588.532op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.060µs 81.237µs ± 0.149µs 81.183µs ± 0.045µs 81.281µs 81.513µs 81.823µs 81.882µs 0.86% 1.919 4.212 0.18% 0.011µs 1 200
credit_card/is_card_number/378282246310005 throughput 12212644.598op/s 12309634.292op/s ± 22441.917op/s 12317885.893op/s ± 6875.456op/s 12323090.361op/s 12331274.356op/s 12335745.151op/s 12336484.377op/s 0.15% -1.905 4.140 0.18% 1586.883op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 59.009µs 59.668µs ± 0.191µs 59.697µs ± 0.104µs 59.788µs 59.938µs 60.002µs 60.117µs 0.70% -0.814 1.145 0.32% 0.014µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16634261.026op/s 16759465.848op/s ± 53795.015op/s 16751165.892op/s ± 29081.154op/s 16786786.978op/s 16873065.189op/s 16922819.405op/s 16946625.250op/s 1.17% 0.838 1.196 0.32% 3803.882op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.831µs 6.843µs ± 0.007µs 6.842µs ± 0.001µs 6.844µs 6.849µs 6.855µs 6.916µs 1.08% 7.812 80.760 0.09% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 144601574.199op/s 146141248.879op/s ± 137835.456op/s 146159718.382op/s ± 31583.749op/s 146189605.919op/s 146244776.496op/s 146330219.866op/s 146383198.573op/s 0.15% -7.750 79.807 0.09% 9746.439op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.621µs 4.633µs ± 0.004µs 4.633µs ± 0.002µs 4.635µs 4.638µs 4.641µs 4.642µs 0.19% -0.484 0.606 0.08% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 215431221.662op/s 215850162.867op/s ± 172363.647op/s 215837968.168op/s ± 102008.972op/s 215943447.824op/s 216150831.174op/s 216352406.131op/s 216421098.722op/s 0.27% 0.489 0.614 0.08% 12187.950op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 73.136µs 73.636µs ± 0.165µs 73.644µs ± 0.081µs 73.722µs 73.830µs 74.335µs 74.439µs 1.08% 0.857 6.089 0.22% 0.012µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 13433757.254op/s 13580358.714op/s ± 30307.729op/s 13578770.957op/s ± 14935.609op/s 13594265.610op/s 13630911.821op/s 13661600.613op/s 13673204.972op/s 0.70% -0.808 5.916 0.22% 2143.080op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 64.770µs 65.209µs ± 0.226µs 65.198µs ± 0.157µs 65.355µs 65.602µs 65.835µs 66.189µs 1.52% 0.673 1.276 0.35% 0.016µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15108185.399op/s 15335526.092op/s ± 52922.876op/s 15337824.302op/s ± 36786.060op/s 15374543.989op/s 15417143.752op/s 15433619.460op/s 15439364.203op/s 0.66% -0.644 1.184 0.34% 3742.212op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.620µs 4.632µs ± 0.004µs 4.632µs ± 0.003µs 4.636µs 4.638µs 4.641µs 4.646µs 0.29% -0.318 -0.038 0.10% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215250095.387op/s 215874115.489op/s ± 206003.256op/s 215866778.103op/s ± 146171.360op/s 216003719.586op/s 216222409.235op/s 216418472.701op/s 216454686.780op/s 0.27% 0.323 -0.036 0.10% 14566.630op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 62.880µs 63.489µs ± 0.159µs 63.504µs ± 0.095µs 63.593µs 63.700µs 63.795µs 63.951µs 0.70% -0.869 1.820 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 15637072.649op/s 15750905.870op/s ± 39455.372op/s 15746924.992op/s ± 23418.278op/s 15772540.796op/s 15818611.781op/s 15873295.505op/s 15903319.093op/s 0.99% 0.892 1.875 0.25% 2789.916op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 59.309µs 59.662µs ± 0.152µs 59.676µs ± 0.119µs 59.782µs 59.875µs 59.966µs 60.036µs 0.60% -0.142 -0.819 0.25% 0.011µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16656799.826op/s 16761259.738op/s ± 42760.101op/s 16757268.965op/s ± 33542.650op/s 16795082.411op/s 16832511.576op/s 16841863.239op/s 16860847.426op/s 0.62% 0.151 -0.818 0.25% 3023.596op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.832µs 6.842µs ± 0.004µs 6.841µs ± 0.002µs 6.844µs 6.848µs 6.851µs 6.863µs 0.33% 1.085 4.902 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 145698433.144op/s 146164479.426op/s ± 81901.578op/s 146172621.875op/s ± 43170.991op/s 146210534.470op/s 146301902.934op/s 146327535.473op/s 146361978.802op/s 0.13% -1.076 4.853 0.06% 5791.316op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.633µs; 4.634µs] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ throughput [215794825.286op/s; 215846895.051op/s] or [-0.012%; +0.012%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.656µs; 91.811µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10892575.052op/s; 10910534.240op/s] or [-0.082%; +0.082%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [84.008µs; 84.109µs] or [-0.060%; +0.060%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11889904.818op/s; 11903465.462op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number/37828224631 execution_time [4.632µs; 4.634µs] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/37828224631 throughput [215805515.387op/s; 215882301.022op/s] or [-0.018%; +0.018%] None None None
credit_card/is_card_number/378282246310005 execution_time [81.217µs; 81.258µs] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/378282246310005 throughput [12306524.058op/s; 12312744.526op/s] or [-0.025%; +0.025%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [59.642µs; 59.695µs] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [16752010.376op/s; 16766921.320op/s] or [-0.044%; +0.044%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.842µs; 6.844µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number/x371413321323331 throughput [146122146.210op/s; 146160351.547op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.632µs; 4.633µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ throughput [215826274.923op/s; 215874050.811op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [73.613µs; 73.659µs] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [13576158.355op/s; 13584559.074op/s] or [-0.031%; +0.031%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [65.178µs; 65.240µs] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15328191.490op/s; 15342860.694op/s] or [-0.048%; +0.048%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.632µs; 4.633µs] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [215845565.419op/s; 215902665.559op/s] or [-0.013%; +0.013%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [63.467µs; 63.511µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [15745437.734op/s; 15756374.005op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [59.641µs; 59.683µs] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [16755333.600op/s; 16767185.877op/s] or [-0.035%; +0.035%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.841µs; 6.842µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [146153128.655op/s; 146175830.197op/s] or [-0.008%; +0.008%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 9b34032 1732313007 gleocadie/fix-bug-in-crashtracker
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 138.213µs 139.204µs ± 0.352µs 139.133µs ± 0.141µs 139.319µs 139.781µs 140.213µs 141.388µs 1.62% 2.407 11.382 0.25% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [139.155µs; 139.253µs] or [-0.035%; +0.035%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 70.76%. Comparing base (191a68a) to head (9b34032).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #756      +/-   ##
==========================================
- Coverage   70.79%   70.76%   -0.03%     
==========================================
  Files         297      297              
  Lines       43568    43584      +16     
==========================================
+ Hits        30843    30844       +1     
- Misses      12725    12740      +15
Components Coverage Δ
crashtracker 43.61% <0.00%> (-0.19%) ⬇️
crashtracker-ffi 8.41% <0.00%> (-0.27%) ⬇️
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.98% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (ø)
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.05% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.76% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 38.01% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.36% <ø> (ø)
trace-normalization 98.23% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.54% <ø> (ø)
---- 🚨 Try these New Features:

@gleocadie gleocadie force-pushed the gleocadie/fix-bug-in-crashtracker branch 3 times, most recently from 9a11462 to 7ef9fcf Compare November 22, 2024 21:58
@gleocadie gleocadie force-pushed the gleocadie/fix-bug-in-crashtracker branch from 7ef9fcf to 9b34032 Compare November 22, 2024 22:03
@gleocadie gleocadie changed the title Run crashinfo test fix(crashtracker) : Fix crash when sending crashinfo Nov 22, 2024
@gleocadie gleocadie marked this pull request as ready for review November 22, 2024 22:12
@gleocadie gleocadie requested a review from a team as a code owner November 22, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gleocadie @codecov-commenter