AMLII-1358 - Updated Generational ZGC to use Major and Minor GC metric names #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosroman
force-pushed
the
carlosroman/Generational-ZGC-update
branch
from
d6644a5 to
86d1f74
Compare
vickenty
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way we map Generational ZGC beans. As this now behaves like previous Garbage collectors that had generations it makes more sense to map them to
MajorandMinorGC metrics. This means that:ZGC Major CyclesandZGC Major Pausesget mapped tojvm.gc.major_collection_<count/time>ZGC Minor CyclesandZGC Minor Pausesget mapped tojvm.gc.minor_collection_<count/time>The benefit of this is that JVM Metrics dashboard that support
MajorandMinorGC metrics will be useable with Generational ZGC.As we haven't release a new version of JMXFetch, no one should be using the previous mappings in #502.