[build] bumping log4j2 to 2.12.2 for sanity + pinning mvn-deploy-plugin #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Dec 14, 2021
sgnn7
approved these changes
Dec 14, 2021
truthbk
added a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being unaffected by https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2021-45046 after our previous mitigation effort, the Apache foundation has released log4j
v2.12.2which remains Java7 compatible while entirely removing the message lookups feature and explicitly disabling JNDI access as per: https://logging.apache.org/log4j/2.x/.As such, and for sanity and housekeeping we should bump to said log4j version number.
Finally, this PR also sets a pin on the
mvn-deploy-pluginto guarantee the stability of the build (and is entirely unrelated to the log4j change).