Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty include in configuration #348

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

hush-hush
Copy link
Member

An empty 'include' configuration would produce a beanScrope of ':' and
would match every bean from the server without applying any of the
default configuration

truthbk
truthbk previously approved these changes Jan 5, 2021
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If we could add a small unit test to cover this fix, that would be great.

An empty 'include' configuration would produce a beanScrope of '*:*' and
would match every bean from the server without applying any of the
default configuration
Copy link
Member

@truthbk truthbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. 👍

We could maybe use getResource() to avoid using paths the way we do, but I know that pattern was already in the unit tests, so feel free to ignore.

@hush-hush hush-hush merged commit 180bb69 into master Jan 13, 2021
@hush-hush hush-hush deleted the maxime/fix-empty-include branch January 13, 2021 11:31
@truthbk truthbk added this to the 0.42.0 milestone Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants