Replace jackson databind with lightweight jackson-jr-objects #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ich allows a large (2.7MB) dependency to be dropped from size-sensitive deployments
Merged
truthbk
approved these changes
Sep 3, 2020
| @@ -122,11 +120,11 @@ private String generateYaml() { | |||
| return yaml.dump(status); | |||
| } | |||
|
|
|||
| private String generateJson() throws JsonProcessingException { | |||
| private String generateJson() throws IOException { | |||
There was a problem hiding this comment.
note: this looks OK to me, but I'm not sure this is well covered in our tests.
There was a problem hiding this comment.
OK I will add some testing before merging this
There was a problem hiding this comment.
Actually I can see why there isn't much testing for this now - I don't really have time to refactor this for testability right now. Is there another way I can find if this still works the way it's supposed to?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces jackson databind (full blown object mapping) with a lightweight version which actually uses the same internals for the JSON mapping use cases (maps, lists, strings, primitives) found in this project, will save 1.3MB in deployment size, builds on #319, #320