Replace LinkedList by ArrayList and or List #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinkedList are heavier regarding memory footprint, we prefer to void its usage by just replacing by ArrayList. I have changed also the type to use List interface as it will be easier to change implementation if required. Some lists are also pre-sized when possible.
devinsba
approved these changes
Feb 12, 2020
| } | ||
| return Collections.singletonList((String) toCast); |
There was a problem hiding this comment.
I just want to make sure the result of this call is not expected to be modified anywhere. I see one assignment to a instance variable this.excludeTags
There was a problem hiding this comment.
You're right, there is some add operations on it afterward
truthbk
approved these changes
Feb 18, 2020
| @@ -116,7 +115,7 @@ private void addAdditionalTags() { | |||
| if (include != null) { | |||
| for (Map.Entry<String, String> tag : include.getAdditionalTags().entrySet()) { | |||
| String alias = this.replaceByAlias(tag.getValue()); | |||
| if ((alias.trim().length() > 0) && alias != null) { | |||
| if (alias != null && alias.trim().length() > 0) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinkedList are heavier regarding memory footprint, we prefer to void
its usage by just replacing by ArrayList.
I have changed also the type to use List interface as it will be
easier to change implementation if required.
Some lists are also pre-sized when possible.