[rate] add canonical_rate + feature flag for the feature #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
approved these changes
Aug 24, 2017
| boolean submit = (!Double.isNaN(rate) && !Double.isInfinite(rate)); | ||
| submit &= (rate >= 0 | !canonicalRate); | ||
|
|
||
| if (submit) { | ||
| sendMetricPoint(metricType, metricName, rate, tags); | ||
| } |
There was a problem hiding this comment.
nit: I think we should log something when we don't submit a metric because canonicalRate is enabled, could ease troubleshooting missing rates.
truthbk
changed the title
truthbk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feature flag to enable canonical rate behavior for counters/rates such that a negative rate would not be reported. A legit negative rate would typically represent a metric that should be reported as a
gauge. Because the former inconsistent behavior has been present in jmxfetch for a while, and to avoid breaking alerts and dashboards, we will put this behind a feature flag for now.Based off #146