Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[instance] support instance tags in list format #132

Merged
merged 1 commit into from
Mar 3, 2017

Conversation

yannmh
Copy link
Member

@yannmh yannmh commented Mar 3, 2017

Support instance tags defined in an array/list format.

Fix #131

@yannmh yannmh added this to the 0.13.0 milestone Mar 3, 2017
@yannmh yannmh self-assigned this Mar 3, 2017
@yannmh yannmh requested a review from olivielpeau March 3, 2017 15:26
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had one nit.

We should spend some time in the future to normalize the format of the tags parameter that can be set on the instance/include-exclude/attribute level so that there's one recommended format.

beanTags.add(tag.getKey() + ":" + tag.getValue());
if (tag.getValue() != null) {
beanTags.add(tag.getKey() + ":" + tag.getValue());

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove the extra blank line here?

Support instance tags defined in an array/list format.
@yannmh yannmh force-pushed the yann/support-tags-arrays branch from 84cc9b6 to 94cbee9 Compare March 3, 2017 19:07
@yannmh yannmh merged commit aaa8be4 into master Mar 3, 2017
@yannmh yannmh deleted the yann/support-tags-arrays branch March 3, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants