[attribute] add TabularData support #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original discussion thread: #111
Credits to @brothhaar. Thanks a lot !!! 🙇
JMX TabularData support
Copied from #111, @brothhaar.
When a TabularData type is encountered, multiple metrics are generated with the same alias, but a unique tag per entry.
The tag is generated by concatenating each of the (possibly multiple) key values for each CompositeData entry in the TabularData JMX value
Also included limit and sort capability to allow sorting and limiting the number of metrics returned for a single configuration entry (since a TabularData value could have many records).
YAML config format:
Additional changes
Allow tag substitution for any key of a
TabularData
objectDo not restrain tag substitution to the
TabularType
index. Instead, tag subtitution can be performed on any keys of aCompositeType
.For example:
instruments JMXFetch to collect a
multiattr.foo
metric tagged withfoo
andtoto
keys, wherefoo
andtoto
areCompositeType
keys.Others
sort
andlimit
forTabularData
JMXMultiAttribute
toJMXTabularAttribute