Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxime/add additional tags option #117

Merged
merged 1 commit into from
Dec 15, 2016

Conversation

hush-hush
Copy link
Member

Add 'additional_tags' list to the configuration: ref #108

This allows a user to define additional tag at the 'include' level (with alias using the '$tag_name' notation).

@yannmh
Copy link
Member

yannmh commented Dec 9, 2016

Can we name it tags instead of additional_tags ? I realized this is how we name it in most of our checks shipped with the Datadog Agent.

@hush-hush
Copy link
Member Author

We already have a 'tags' section in the instances section and aliasing is not handled in that one. Do we mind having the same name for 2 sections ?

@yannmh
Copy link
Member

yannmh commented Dec 12, 2016

I think it makes sense: both fields represent additional tags, at different levels (instance versus attribute).

This allows a user to define additional tag at the 'include' level (with alias using the '' notation).
@hush-hush hush-hush force-pushed the maxime/add-additional_tags-option branch from 410ddf9 to 2106933 Compare December 13, 2016 14:11
@hush-hush hush-hush requested a review from yannmh December 14, 2016 15:03
Copy link
Member

@yannmh yannmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great !

@hush-hush hush-hush merged commit 83f571f into master Dec 15, 2016
@hush-hush hush-hush deleted the maxime/add-additional_tags-option branch December 15, 2016 09:43
@olivielpeau olivielpeau added this to the 0.13.0 milestone Jan 31, 2017
sv3ndk added a commit to sv3ndk/documentation that referenced this pull request Jul 21, 2017
- the 'tags' entry was added to jmxfetch in release 0.14 (see this PR: DataDog/jmxfetch#117)
- this commit adds to the java integration how to use this new 'tags' option to append new tags manually to a metric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants