From ebf88fd37e5aa32949ef8fd3cb063398fc991c1c Mon Sep 17 00:00:00 2001 From: Alex Normand Date: Thu, 29 Apr 2021 10:38:19 -0700 Subject: [PATCH 1/2] Change 'collision in cached query metrics' log from debug to error --- .../datadog_checks/base/utils/db/statement_metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py b/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py index 2ee0dbdd3d38c..05ec7e8238617 100644 --- a/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py +++ b/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py @@ -57,7 +57,7 @@ def compute_derivative_rows(self, rows, metrics, key): for row in rows: row_key = key(row) if row_key in new_cache: - logger.debug( + logger.error( 'Collision in cached query metrics. Dropping existing row, row_key=%s new=%s dropped=%s', row_key, row, From 056d06747513dd064886b1eee5c6b21edbf7308a Mon Sep 17 00:00:00 2001 From: Alex Normand Date: Thu, 29 Apr 2021 11:11:15 -0700 Subject: [PATCH 2/2] Update log message to provide a stronger hint that collisions are not expected --- .../datadog_checks/base/utils/db/statement_metrics.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py b/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py index 05ec7e8238617..a5e483a20ffcb 100644 --- a/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py +++ b/datadog_checks_base/datadog_checks/base/utils/db/statement_metrics.py @@ -58,7 +58,7 @@ def compute_derivative_rows(self, rows, metrics, key): row_key = key(row) if row_key in new_cache: logger.error( - 'Collision in cached query metrics. Dropping existing row, row_key=%s new=%s dropped=%s', + 'Unexpected collision in cached query metrics. Dropping existing row, row_key=%s new=%s dropped=%s', row_key, row, new_cache[row_key],