From faee9b669835ec512ab050370cd35eb504472dbc Mon Sep 17 00:00:00 2001 From: Marc Ian Bucad Date: Tue, 24 Mar 2020 10:29:15 +0800 Subject: [PATCH 1/3] Adds some logging to determine what path is likely hitting the max allowed metrics --- go_expvar/datadog_checks/go_expvar/go_expvar.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/go_expvar/datadog_checks/go_expvar/go_expvar.py b/go_expvar/datadog_checks/go_expvar/go_expvar.py index 96b736579601a..28d0ae77f1ac3 100644 --- a/go_expvar/datadog_checks/go_expvar/go_expvar.py +++ b/go_expvar/datadog_checks/go_expvar/go_expvar.py @@ -157,6 +157,7 @@ def parse_expvar_data(self, data, tags, metrics, max_metrics, namespace): if len(values) == 0: self.warning("No results matching path %s", path) continue + self.log.debug("%s result(s) matching path %s", len(values), path) tag_by_path = alias is not None @@ -169,10 +170,11 @@ def parse_expvar_data(self, data, tags, metrics, max_metrics, namespace): try: float(value) except (TypeError, ValueError): - self.log.warning("Unreportable value for path %s: %s", path, value) + self.log.warning("Unreportable value for path %s: %s", actual_path, value) continue if count >= max_metrics: + self.log.warning("Exceeded maximum allowed metrics (%s) while processing: %s", max_metrics, metric_name) self.warning( "Reporting more metrics than the allowed maximum. " "Please contact support@datadoghq.com for more information." From 55acfbbb23ca469c975c87bb393857c3a1ca0686 Mon Sep 17 00:00:00 2001 From: Marc Ian Bucad Date: Tue, 24 Mar 2020 10:41:29 +0800 Subject: [PATCH 2/3] style fix --- go_expvar/datadog_checks/go_expvar/go_expvar.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/go_expvar/datadog_checks/go_expvar/go_expvar.py b/go_expvar/datadog_checks/go_expvar/go_expvar.py index 28d0ae77f1ac3..b978f079e4cd4 100644 --- a/go_expvar/datadog_checks/go_expvar/go_expvar.py +++ b/go_expvar/datadog_checks/go_expvar/go_expvar.py @@ -174,7 +174,9 @@ def parse_expvar_data(self, data, tags, metrics, max_metrics, namespace): continue if count >= max_metrics: - self.log.warning("Exceeded maximum allowed metrics (%s) while processing: %s", max_metrics, metric_name) + self.log.warning( + "Exceeded maximum allowed metrics (%s) while processing: %s", max_metrics, metric_name + ) self.warning( "Reporting more metrics than the allowed maximum. " "Please contact support@datadoghq.com for more information." From 44eac568c384465483cc3ccdcac905db8197c898 Mon Sep 17 00:00:00 2001 From: Marc Ian Bucad Date: Wed, 1 Apr 2020 09:03:14 +0800 Subject: [PATCH 3/3] Change to debug level log --- go_expvar/datadog_checks/go_expvar/go_expvar.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/go_expvar/datadog_checks/go_expvar/go_expvar.py b/go_expvar/datadog_checks/go_expvar/go_expvar.py index b978f079e4cd4..d8720458954d4 100644 --- a/go_expvar/datadog_checks/go_expvar/go_expvar.py +++ b/go_expvar/datadog_checks/go_expvar/go_expvar.py @@ -174,7 +174,7 @@ def parse_expvar_data(self, data, tags, metrics, max_metrics, namespace): continue if count >= max_metrics: - self.log.warning( + self.log.debug( "Exceeded maximum allowed metrics (%s) while processing: %s", max_metrics, metric_name ) self.warning(