[Disk] Collect disk latency metrics for non-Windows OS #1018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hush-hush
previously approved these changes
Jan 18, 2018
disk/datadog_checks/disk/disk.py
Outdated
| except AttributeError: | ||
| # Some OS don't return read_time/write_time fields | ||
| # http://psutil.readthedocs.io/en/latest/#psutil.disk_io_counters | ||
| self.log.debug("Latency metrics not collected for {0}".format(disk_name)) |
There was a problem hiding this comment.
We should log why it's not being collected. Like: `Latency metrics not available for {0}" ?
There was a problem hiding this comment.
thanks @hush-hush. I added the error when logging to be more clear why it's not collected. let me know what you think
hush-hush
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allows the check to pull disk latency metrics (
system.disk.read_time_pct,system.disk.write_time_pct) from non-windows OS. Also updatescollect_latency_metrics()function to not fail in case the fields aren't available to pull these metrics, which is expected for some operating systems.Motivation
Customer reached out wanting to be able to collect these disk latency metrics and previously the check only collected for Windows hosts
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Versioning
manifest.jsondatadog_checks/{integration}/__init__.pyCHANGELOG.md. Please useUnreleasedas the date in the titlefor the new section.
Additional Notes
Anything else we should know when reviewing?