-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move env vars to configuration settings #985
Conversation
3c642ba
to
90f4825
Compare
Something things I'd still like to do with this before its ready:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so far looks good to me
90f4825
to
d2e80fc
Compare
d2e80fc
to
4912342
Compare
Decided to hold off on deprecation warnings for now; want to give this a thorough treatment but the changes are probably too much for this PR. Should be ready for a final review pending CI passing. |
Looks like there was a bug where setting EDIT: Never mind, this is evidently intentional behavior for custom loggers. The test for this was doing too many things at once and conflating things a bit; refactored it a bit for correctness and clarity. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!
325541a
to
2bf178f
Compare
2bf178f
to
1c0fbb6
Compare
We'd like
service
,env
,tags
, andversion
to be configurable fromDatadog.configure
as well as from their respective environment variables.This pull request moves these into
Datadog::Configuration::Settings
to make them configurable.