Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI Actionpack 5.2.4.2 syntax error breaking Ruby 2.2 #981

Merged
merged 1 commit into from
Mar 20, 2020
Merged

Fix CI Actionpack 5.2.4.2 syntax error breaking Ruby 2.2 #981

merged 1 commit into from
Mar 20, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Mar 20, 2020

A continuation of #894, the 5.2.4.2 Rails release does not include the bugfix for the Ruby 2.2 syntax error. This prevents CI from breaking.

@delner delner added the dev/testing Involves testing processes (e.g. RSpec) label Mar 20, 2020
@delner delner added this to the 0.34.0 milestone Mar 20, 2020
@delner delner requested review from marcotc and a team March 20, 2020 16:51
@delner delner self-assigned this Mar 20, 2020
brettlangdon
brettlangdon approved these changes Mar 20, 2020
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun

@delner delner merged commit e7418f7 into master Mar 20, 2020
@delner delner deleted the ci/prevent_actionpack_5.2.4.2_syntax_error branch March 20, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@marcotc marcotc Awaiting requested review from marcotc

Assignees

@delner delner

Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Milestone
0.34.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @brettlangdon