Faraday integration default instrumentation #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #786
This PR adds a default Faraday middleware handler to allow for
ddtrace
users to be able to instrument it out-of-the-box, by simply enabling it:Currently we also require users to explicitly configure our middleware on every Faraday connection:
This per-connection configuration won't be necessary anymore, unless custom configuration settings are desired for that connection.