Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Official support for Ruby 2.5 and 2.6 #802

Merged
merged 32 commits into from
Sep 4, 2019
Merged

Official support for Ruby 2.5 and 2.6 #802

merged 32 commits into from
Sep 4, 2019

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 30, 2019 •
edited
Loading

Fixes #800

Add official support for Ruby 2.5 and Ruby 2.6.
dd-trace-rb already supported with these new versions of Ruby, but we've introduced proper test coverage around such versions.

@marcotc marcotc changed the title Official support for Ruby 2.5, 2.6, 2.7 Official support for Ruby 2.5 and 2.6 Sep 3, 2019
@marcotc marcotc marked this pull request as ready for review September 3, 2019 21:59
@marcotc marcotc requested a review from a team September 3, 2019 21:59
@marcotc marcotc added the feature Involves a product feature label Sep 3, 2019
@delner delner self-requested a review September 3, 2019 22:46
@delner delner added this to the 0.27.0 milestone Sep 3, 2019
delner
delner reviewed Sep 4, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy with this; just need to make a few minor alterations.

Rakefile Show resolved Hide resolved
docs/GettingStarted.md Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
delner
delner reviewed Sep 4, 2019
View reviewed changes
Rakefile Show resolved Hide resolved
delner
delner approved these changes Sep 4, 2019
View reviewed changes
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! 👍

@delner delner added the core Involves Datadog core libraries label Sep 4, 2019
@marcotc marcotc merged commit cf2846e into 0.27-dev Sep 4, 2019
@marcotc marcotc deleted the feature/ruby-2_5-2_6-2_7 branch September 4, 2019 17:35
@f3ndot
Copy link

f3ndot commented Sep 6, 2019

thanks bub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delner delner delner approved these changes

Assignees

@marcotc marcotc

Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcotc @f3ndot @delner