-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics_sample_rate to all integrations #697
Add analytics_sample_rate to all integrations #697
Conversation
6bcb655
to
00f099b
Compare
We want to use There should be 1 global configuration option Each integration will then have it's own 2 configuration options:
For web frameworks, we should set the tag with For everything else, we should set the tag with |
e4022ef
to
f2793f6
Compare
@brettlangdon All of the existing commits have been updated to match the name changes and logic, with the exception of the global flag (which does not yet exist.) I will carry on updating the remaining integrations from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these changes look good so far!
d308cc9
to
4d372c6
Compare
4d372c6
to
21764ad
Compare
@brettlangdon Ready for review. Worth pointing out Rails, Sinatra and all the other integrations in this PR are off by default, and will ignore the global flag unless explicitly enabled. Let me know if you'd like to change that behavior. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably only want the request spans to have analytics and can remove setting the tag for rendering spans.
Otherwise, this is good to go!
ba644e9
to
34ae074
Compare
34ae074
to
b7660eb
Compare
@brettlangdon Removed tags from render & cache spans, fixed a constant name, and changed defaults such that only Grape, GraphQL, Rack, Rails, & Sinatra will be toggled by the global flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d-(^-^)-b
Using the feature defined in #665, and as a follow up to #666, this pull request adds the event sample rate tag, if configured, to the following integrations: