[resque] Shutdown tracer and flush data on job finish instead of using SyncWriter. #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelchcki
changed the title
pawelchcki
added
do-not-merge/WIP
|
@pawelchcki This is marked as WIP: is it ready for review? |
|
@delner for now there is no pressing need to disable SyncWriter. I'll close this PR for now |
palazzem
reviewed
Jul 17, 2018
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
|
|
||
| Resque.before_first_fork do |
There was a problem hiding this comment.
are we sure of that change? I remember we added it to handle some cases. We need to deeply test those changes.
There was a problem hiding this comment.
We want to ship it first as a beta release and before that do another round of testing.
I've tested this change locally when developing it and coupled with some other improvements in separate PRs, it did flush and shutdown as quickly as SyncWriter.
This change is mostly driven by the fact that SyncWriter performance deteriorates quite a bit under multithreaded setup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using latest improvements to how shutdown is performed - we can safely and quickly flush all data manually when the job has finished running.
Its faster and safer than SyncWriter that needs to spawn two threads and connection to the agent on each trace write.