[APPSEC-56128] Replace telemetry error with report #4222
Closed
+16
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replace AppSec telemetry error with report upon receiving internal "implicit" error of
libddwaf
.Motivation:
This change is a part-done set of changes in order to have a single monitor to control issues with
libddwaf
calls.With this change we will be able to see errors both "implicit" and explicit in the same place to build a Monitor around them.
(example picture for reference - live log)We have a task to replace exceptions in
libddwaf-rb
with return status Result (implicit error) which means two things:Result
object fromlibddwaf-rb
(decouple from its origin interface)Change log entry
No.
Additional Notes:
In order to deliver log which will appear in ErrorTracking I need a backtrace and a faster backtrace collection appears only in Ruby 3.4.0.
Telemetry to ErrorTracking is not in the perfect state, which means errors will have a generic name instead of a name of exception. But I've added this request to the APM Language team.
How to test the change?
CI is enough