Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc:OpenTelemetry and JRuby 9.4 support doc #4216

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Doc:OpenTelemetry and JRuby 9.4 support doc #4216

merged 2 commits into from
Dec 11, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 10, 2024

Adds a couple of missing support entries to our compatibility documentation (https://docs.datadoghq.com/tracing/trace_collection/compatibility/ruby/).

Change log entry
No

@marcotc marcotc requested a review from a team as a code owner December 10, 2024 18:41
@marcotc marcotc added the docs Involves documentation label Dec 10, 2024
@marcotc marcotc self-assigned this Dec 10, 2024
@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Dec 10, 2024
docs/Compatibility.md Outdated Show resolved Hide resolved
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 10, 2024

Datadog Report

Branch report: support-jruby
Commit report: b4c8a32
Test service: dd-trace-rb

✅ 0 Failed, 22067 Passed, 1457 Skipped, 5m 31.62s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (8ebc8a1) to head (5922af1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4216      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       82131    82131              
  Branches     4174     4174              
==========================================
- Hits        80302    80296       -6     
- Misses       1829     1835       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-11 20:04:49

Comparing candidate commit b4c8a32 in PR branch support-jruby with baseline commit 8ebc8a1 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.601op/s; -0.589op/s] or [-9.101%; -8.930%]

Copy link
Member

@p-datadog p-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the support type added to the OpenTelemetry line.

@marcotc marcotc enabled auto-merge December 11, 2024 19:41
@marcotc marcotc requested a review from neko-dd December 11, 2024 19:41
@marcotc marcotc merged commit 77c54a8 into master Dec 11, 2024
339 of 340 checks passed
@marcotc marcotc deleted the support-jruby branch December 11, 2024 20:34
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants