Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to version 2.8.0 #4215

Merged
merged 4 commits into from
Dec 10, 2024
Merged

Bump to version 2.8.0 #4215

merged 4 commits into from
Dec 10, 2024

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Dec 10, 2024

Added

Changed

Fixed

@ivoanjo ivoanjo requested a review from a team as a code owner December 10, 2024 16:15
Copy link

👋 Hey @ivoanjo, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2024-12-10 16:15:57 UTC

@p-datadog
Copy link
Member

We put DI into Highlights section which wasn't added to the diff in this PR and now DI isn't mentioned in the changelog for the release at all.

@pr-commenter
Copy link

pr-commenter bot commented Dec 10, 2024

Benchmarks

Benchmark execution time: 2024-12-10 16:52:46

Comparing candidate commit 51d61a3 in PR branch bump_to_version_2.8.0 with baseline commit 18171cc in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:profiler - sample timeline=false

  • 🟥 throughput [-0.473op/s; -0.427op/s] or [-7.301%; -6.586%]

scenario:tracing - Propagation - Datadog

  • 🟥 throughput [-3027.913op/s; -2955.794op/s] or [-9.177%; -8.958%]

scenario:tracing - Tracing.log_correlation

  • 🟥 throughput [-8073.458op/s; -7687.522op/s] or [-6.754%; -6.431%]

@ivoanjo ivoanjo merged commit 8ebc8a1 into master Dec 10, 2024
349 of 351 checks passed
@ivoanjo ivoanjo deleted the bump_to_version_2.8.0 branch December 10, 2024 16:54
@github-actions github-actions bot added this to the 2.8.0 milestone Dec 10, 2024
@ivoanjo
Copy link
Member Author

ivoanjo commented Dec 10, 2024

We spotted the broken system-tests, we're going to take a look at them separately :)

@p-datadog
Copy link
Member

PR to skip failing test in all dd-trace-rb versions: DataDog/system-tests#3655

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (18171cc) to head (51d61a3).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4215   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files        1357     1357           
  Lines       82130    82130           
  Branches     4174     4174           
=======================================
+ Hits        80296    80297    +1     
+ Misses       1834     1833    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants