Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean JRuby Gemfiles #4213

Merged
merged 7 commits into from
Dec 11, 2024
Merged

Clean JRuby Gemfiles #4213

merged 7 commits into from
Dec 11, 2024

Conversation

sarahchen6
Copy link
Contributor

What does this PR do?
This PR removes if statements and alphabetizes jruby-x.gemfiles.

Motivation:
Since gemfiles are no longer symlinked, we can begin removing if statements and generally cleaning each file.

Change log entry
None.

Additional Notes:
N/A

How to test the change?
Green CI.

@pr-commenter
Copy link

pr-commenter bot commented Dec 9, 2024

Benchmarks

Benchmark execution time: 2024-12-11 16:03:26

Comparing candidate commit 22b1bff in PR branch sarahchen6/clean-jruby-gemfiles with baseline commit 1be0c46 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (1be0c46) to head (22b1bff).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4213      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       82130    82131       +1     
  Branches     4174     4174              
==========================================
- Hits        80298    80296       -2     
- Misses       1832     1835       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sarahchen6 sarahchen6 marked this pull request as ready for review December 9, 2024 21:48
@sarahchen6 sarahchen6 requested a review from a team as a code owner December 9, 2024 21:48
@sarahchen6 sarahchen6 force-pushed the sarahchen6/clean-jruby-gemfiles branch from f1b35d1 to 8af6990 Compare December 10, 2024 22:37
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Dec 10, 2024

Datadog Report

Branch report: sarahchen6/clean-jruby-gemfiles
Commit report: 22b1bff
Test service: dd-trace-rb

✅ 0 Failed, 22466 Passed, 1470 Skipped, 5m 57.7s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • Tracing benchmarks tracing_trace runs without raising errors - rspec - Last Failure

    Expand for error
     Wait time exhausted!
     
     Failure/Error: raise('Wait time exhausted!')
     
     RuntimeError:
       Wait time exhausted!
     ./spec/support/synchronization_helpers.rb:97:in \`try_wait_until'
     ./spec/support/synchronization_helpers.rb:26:in \`expect_in_fork'
     ./spec/datadog/tracing/validate_benchmarks_spec.rb:19:in \`block (4 levels) in <top (required)>'
     ./spec/datadog/tracing/validate_benchmarks_spec.rb:8:in \`block (3 levels) in <top (required)>'
     ...
    

@sarahchen6 sarahchen6 force-pushed the sarahchen6/clean-jruby-gemfiles branch from 51c0126 to 99e7a90 Compare December 11, 2024 15:32
@sarahchen6 sarahchen6 merged commit 8c41168 into master Dec 11, 2024
349 checks passed
@sarahchen6 sarahchen6 deleted the sarahchen6/clean-jruby-gemfiles branch December 11, 2024 20:26
@github-actions github-actions bot added this to the 2.9.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants