Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sampling by trace resource #3585

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Add sampling by trace resource #3585

merged 1 commit into from
Apr 12, 2024

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Apr 11, 2024

What does this PR do?

This PR expands the sampling rule engine to allow for matching on traces based on their resource names.

Additional Notes:

How to test the change?

There are unit tests in this PR, as well as system tests: https://github.com/DataDog/system-tests/blob/373c58b012da02794385510cb083001f5a0b9013/tests/parametric/test_trace_sampling.py#L195

Unsure? Have a question? Request a review!

Verified

This commit was signed with the committer’s verified signature.
marcotc Marco Costa
Signed-off-by: Marco Costa <marco.costa@datadoghq.com>
@marcotc marcotc requested review from a team as code owners April 11, 2024 20:37
Copy link
Contributor

@alai97 alai97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for docs.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.94737% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.24%. Comparing base (07c75b8) to head (7936288).
Report is 8 commits behind head on master.

Files Patch % Lines
spec/datadog/tracing/sampling/rule_spec.rb 96.55% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3585   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files        1254     1254           
  Lines       74355    74414   +59     
  Branches     3529     3529           
=======================================
+ Hits        73052    73111   +59     
  Misses       1303     1303           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc added this to the 1.22.0 milestone Apr 11, 2024
@marcotc marcotc requested a review from ZStriker19 April 11, 2024 21:23
@marcotc marcotc merged commit 243fb07 into master Apr 12, 2024
207 checks passed
@marcotc marcotc deleted the resource-sampling branch April 12, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants