Remove opentracing support #3443
Conversation
TonyCTHsu
force-pushed
the
tonycthsu/remove-opentracing
branch
from
ec2ac94 to
d3eeb98
Compare
github-actions
bot
added
appsec
TonyCTHsu
force-pushed
the
tonycthsu/remove-opentracing
branch
from
d3eeb98 to
c0d0341
Compare
|
Thoughts on this?
|
| @@ -51,7 +51,6 @@ def before_initialize(app) | |||
| BEFORE_INITIALIZE_ONLY_ONCE_PER_APP[app].run do | |||
| # Middleware must be added before the application is initialized. | |||
| # Otherwise the middleware stack will be frozen. | |||
| # Sometimes we don't want to activate middleware e.g. OpenTracing, etc. | |||
| add_middleware(app) if Datadog.configuration.tracing[:rails][:middleware] | |||
There was a problem hiding this comment.
Does Datadog.configuration.tracing[:rails][:middleware] == false ever make sense?
There was a problem hiding this comment.
I'm thinking where you want the other Rails instrumentation but not the Rack middleware. Very niche, but possible. I'd look at the history of the option before making too many assumptions, though.
| # Sometimes we don't want to activate middleware e.g. OpenTracing, etc. | ||
| add_middleware(app) if Datadog.configuration.tracing[:rails][:middleware] |
There was a problem hiding this comment.
Does Datadog.configuration.tracing[:rails][:middleware] == false ever make sense?
Remove it, it's not even parsed today by our backend. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.0 #3443 +/- ##
==========================================
- Coverage 98.10% 98.07% -0.03%
==========================================
Files 1262 1229 -33
Lines 73316 71801 -1515
Branches 3434 3379 -55
==========================================
- Hits 71923 70416 -1507
+ Misses 1393 1385 -8 ☔ View full report in Codecov by Sentry. |
2.0 Upgrade Guide notes
OpenTracing is no longer supported from 2+.