Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old benchmarks #3265

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Remove old benchmarks #3265

merged 3 commits into from
Nov 23, 2023

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 20, 2023

What does this PR do?

This PR removes the Circle step called benchmark-2.3.

It indirectly reverts the PR that introduced them, #482, which means this PR also remove gems that were installed for this benchmark (ruby-prof).

Motivation:

This benchmark was introduced in #482, but we haven't inspected the results in quite some time, and have since moved to use our own internal benchmark platform.

Additional Notes:

sqlite3 was also introduced by #482, but it is no longer part of the default Gemfile.

How to test the change?

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

Unsure? Have a question? Request a review!

@marcotc marcotc added the dev/internal Other internal work that does not need to be included in the changelog label Nov 20, 2023
@marcotc marcotc requested a review from a team as a code owner November 20, 2023 18:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b4c9019) 98.23% compared to head (7d17fd9) 98.22%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3265      +/-   ##
==========================================
- Coverage   98.23%   98.22%   -0.01%     
==========================================
  Files        1253     1253              
  Lines       72393    72393              
  Branches     3393     3393              
==========================================
- Hits        71112    71111       -1     
- Misses       1281     1282       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcotc marcotc merged commit adc07c4 into master Nov 23, 2023
217 checks passed
@marcotc marcotc deleted the remove-old-benchmarks branch November 23, 2023 21:52
@github-actions github-actions bot added this to the 1.18.0 milestone Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/internal Other internal work that does not need to be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants