WIP:Report correct ActiveSupport cache backend #2262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(blank) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1252
We currently report the globally configured
Rails.configuration.cache_storeas the cache backend tag (rails.cache.backend) regardless if the instrumented ActiveSupport cache object is actually the globalcache_store.This causes applications with multiple caching backends to incorrectly always report
Rails.configuration.cache_storeas the backend of all cache clients.This PR now reports the respective client for the instrument ActiveSupport cache object. Current users should see no change, as the tag value is kept backwards compatible for Rails applications using only the global
cache_storeobject.Users with multiple cache backends will now see them correctly reported in the
rails.cache.backendspan tag.