Fix Rails log tagging in 1.0.0.beta2 #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if config.logger is not set (as in the default new Rails app), config.logger is never set, Rails bootstrap only ever saves the logger in Rails.logger see: - https://github.com/rails/rails/blob/7-0-stable/railties/lib/rails/application/bootstrap.rb#L37-L53 - https://github.com/rails/rails/blob/7-0-stable/railties/lib/rails.rb#L38
|
Thank you so much @cwoodcox! I've allowed test runs for your PR (first time contributors need us to push a button on our side), 🤞 is all green and we get this merged. Thank you again! 🙇 |
|
Lint failed, so I pushed a commit after running |
marcotc
force-pushed
the
fix-log-tagging
branch
from
de55ab9 to
2294299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1986.
I updated the specs to set up the mock Rails logger to be like the default logger that ships in a Rails application. I also tested this in a freshly-generated Rails 7.0 app, and our own production applications. No more warning, and the log tags work correctly.