Allow dd-trace-rb usage in Ruby 3.2 (aka bump maximum version to < 3.3) #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A maximum version was initially added in #1495 because we expected the `ruby2_keywords` method to be removed (see the PR for the discussion). Now Ruby 3.2.0-preview1 is out and `ruby2_keywords` are still there, and there's even a recent change for it in ruby/ruby#5684 that is documented as "ruby2_keywords needed in 3.2+". So for now let's bump the maximum version to < 3.3 to allow the Ruby 3.2 series to be supported and we can keep an eye on the Ruby 3.2 test releases to see if anything changes. (Otherwise, once Ruby 3.2.0 stable is out, we should probably bump this to 3.4, and so on...)
Codecov Report
@@ Coverage Diff @@
## master #1975 +/- ##
==========================================
+ Coverage 97.53% 97.70% +0.16%
==========================================
Files 998 1000 +2
Lines 49006 50448 +1442
==========================================
+ Hits 47800 49289 +1489
+ Misses 1206 1159 -47
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lloeki
approved these changes
Apr 12, 2022
|
Ack! Re-added more context from those first lines in aef2724 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A maximum version was initially added in #1495 because we expected the
ruby2_keywordsmethod to be removed (see the PR for the discussion).Now Ruby 3.2.0-preview1 is out and
ruby2_keywordsare still there, and there's even a recent change for it in ruby/ruby#5684 that is documented as "ruby2_keywords needed in 3.2+".So for now let's bump the maximum version to < 3.3 to allow the Ruby 3.2 series to be supported and we can keep an eye on the Ruby 3.2 test releases to see if anything changes.
(Otherwise, once Ruby 3.2.0 stable is out, we should probably bump this to 3.4, and so on...)