Add user attribution API #1954
Merged
Add user attribution API #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
previously requested changes
Mar 31, 2022
There was a problem hiding this comment.
Adding set_tag should be okay, but I don't think the implementation of this is quite right.
set_usershould not be a facet of the Trace API as its not a part of the trace specification. I think it would be more appropriate if this function were made a part of the AppSec module wrapping theTraceOperation#set_tagbehavior.set_tagshouldn't set tags directly on the root span; not at this level anyways. "Root span" is is a concrete implementation we're trying to abstract away, andTraceOperationis agnostic to how traces are serialized. I think it would be more appropriate ifTraceOperationaccumulated tags for the trace separate from any span, serialized them intoTraceSegmenton#flush!, then let theTraceFormatterapply tags as appropriate to the spans being flushed (e.g. root span or local root span).
lloeki
force-pushed
the
add-user-tracking-api
branch
from
9b4a3e7 to
48d12fa
Compare
|
As discussed, PR split in two parts: user attribution and trace-level tags, this PR being based on #1959. |
lloeki
force-pushed
the
add-user-tracking-api
branch
3 times, most recently
from
d8365d8 to
a23820e
Compare
lloeki
force-pushed
the
add-user-tracking-api
branch
2 times, most recently
from
c534781 to
6566bf9
Compare
Codecov Report
@@ Coverage Diff @@
## master #1954 +/- ##
========================================
Coverage 97.74% 97.74%
========================================
Files 1004 1007 +3
Lines 50738 50902 +164
========================================
+ Hits 49592 49754 +162
- Misses 1146 1148 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
lloeki
force-pushed
the
add-user-tracking-api
branch
from
a68843b to
68a9053
Compare
marcotc
reviewed
Apr 27, 2022
marcotc
reviewed
Apr 27, 2022
marcotc
reviewed
Apr 27, 2022
lloeki
force-pushed
the
add-user-tracking-api
branch
3 times, most recently
from
d2b27d0 to
c2136b2
Compare
4 tasks
|
Huh, CI flakily failed again: JRuby was stuck for 40+min after success and 2.4 (this time) failed after success with: Canceled and restarted. |
lloeki
dismissed
delner’s stale review
Changes addressed: TraceOperation#set_tag has been implemented separately. set_user is not on TraceOperation anymore.
lloeki
force-pushed
the
add-user-tracking-api
branch
from
c2136b2 to
f12229e
Compare
User attribution enables the user to conveniently tag a trace as being tied to a specific user. Behind the scenes this leverages setting a tag at the trace-level.
lloeki
force-pushed
the
add-user-tracking-api
branch
from
f12229e to
a05b16a
Compare
marcotc
approved these changes
May 3, 2022
|
Duh, my Datadog PGP key expired yesterday /facepalms/ (actually they all expired, my other ones since March /double-facepalms/) |
|
Added docs in DataDog/documentation#13941 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User attribution enables the user to conveniently tag a trace as being tied to a specific user.
Behind the scenes this leverages setting a tag at the trace-level. Since trace transport does not have a concept of trace, tags are set on the topmost span.
When partial flushing is involved, the topmost span will be sent upon last flush, therefore tags will only appear in the UI when that final segment is processed.