Update ruleset to v1.2.6 #1937
Merged
Update ruleset to v1.2.6 #1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivoanjo
approved these changes
Mar 14, 2022
There was a problem hiding this comment.
👍 LGTM.
I would suggest amending the commit message and the PR title to state that it's actually not v1.2.6, as otherwise it's kinda misleading to state it.
(To be honest this is one of those cases where saying something wrong is better than saying nothing IMO).
Otherwise, fire away!
Merged
From a high-level PoV it is 1.2.6 ruleset content, subsequent commits were only done to address the oversight of not having rebuilt two of those files, so it's only pedantically "not 1.2.6" ;) But I'll add a note in the commit body nonetheless. |
Fetched from https://github.com/DataDog/appsec-event-rules/tree/0958752d77604fd2f0b8fd3d778ec5639f4f96c2/build Tag 1.2.6 missed a rebuild for risky and strict, so they got fetched from the above commit, where they have been subsequently rebuilt.
lloeki
force-pushed
the
appsec-update-ruleset
branch
from
c3a3ec0 to
8ccf896
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetched from https://github.com/DataDog/appsec-event-rules/tree/0958752d77604fd2f0b8fd3d778ec5639f4f96c2/build
Tag
1.2.6missed a rebuild forriskyandstrict, so they got fetched from the above commit, where they have been subsequently rebuilt.