AgentSettingsResolver cleanups and spec improvements
#1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because we know that the result of `try_parsing_as_integer` is always going to be used to create a `DetectedConfiguration`, let's do that directly, rather than requiring the caller to take an extra hop.
Previously, we had specs for the port priority spread out which made it hard to change priority or add new items. By extracting the priority to a single set of specs, it's clear what the entire priority is, and there's a single place to change and add to it.
This mirrors the same refactor that was done to the port specs: rather than having the host spec priority specs spread out, we have a single set of specs that validate the priority.
luhenry
approved these changes
Mar 15, 2022
delner
approved these changes
Mar 18, 2022
delner
added
core
|
I thank thee for thee reviews! Merging ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a change to the
AgentSettingsResolverand decided to extract these cleanups/fixes out of that branch to make it easier to review and have them merged sooner.See the individual commits for details on each change.
Note that this PR does not change any observable behavior.