Move ENVIRONMENT_AGENT_SETTINGS to class/specs that need it #1930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ENVIRONMENT_AGENT_SETTINGS` constant was introduced to support a few classes/specs that needed an `agent_settings` object to fall back to. Since there are so little users of this constant (which is good), let's remove it from the `AgentSettingsResolver` class and instead move it to the class/specs that make use of it. This way, the weight of legacy/weird behavior is on the classes that need it, rather than on the `AgentSettingsResolver` class.
luhenry
approved these changes
Mar 15, 2022
delner
approved these changes
Mar 18, 2022
delner
added
core
|
Thanks y'all, merging ahoy! |
ivoanjo
deleted the
ivoanjo/remove-deprecated-usage-of-environment-settings
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ENVIRONMENT_AGENT_SETTINGSconstant was introduced to support a few classes/specs that needed anagent_settingsobject to fall back to.Since there are so little users of this constant (which is good), let's remove it from the
AgentSettingsResolverclass and instead move it to the class/specs that make use of it.This way, the weight of legacy/weird behavior is on the classes that need it, rather than on the
AgentSettingsResolverclass.