Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move integration settings into tracing namespace #1922

Merged
merged 3 commits into from
Mar 15, 2022

Conversation

delner
Copy link
Contributor

@delner delner commented Feb 28, 2022

For consistency, this pull request moves the Contrib extensions for settings from Datadog.configuration to Datadog.configuration.tracing. This was done to ensure usage like Datadog.configuration.tracing[:rails], which is unambiguous as to which feature it belongs.

All integrations have been updated accordingly, and a change the the UpgradeGuide has been added to match.

@delner delner added integrations Involves tracing integrations breaking-change Involves a breaking change dev/refactor Involves refactoring existing components labels Feb 28, 2022
@delner delner added this to the 1.0.0.beta2 milestone Feb 28, 2022
@delner delner requested review from lloeki and ivoanjo February 28, 2022 23:50
@delner delner self-assigned this Feb 28, 2022
@delner delner requested a review from a team February 28, 2022 23:50
Base automatically changed from update_gemfiles to master March 1, 2022 08:54
@delner delner force-pushed the refactor/tracer_integration_settings branch from f69f860 to c7f5ae6 Compare March 1, 2022 15:16
@codecov-commenter
Copy link

Codecov Report

Merging #1922 (c7f5ae6) into master (32fc71b) will decrease coverage by 0.00%.
The diff coverage is 92.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
- Coverage   97.51%   97.50%   -0.01%     
==========================================
  Files         997      997              
  Lines       48737    48747      +10     
==========================================
+ Hits        47524    47532       +8     
- Misses       1213     1215       +2     
Impacted Files Coverage Δ
lib/datadog/appsec/contrib/rails/patcher.rb 44.06% <0.00%> (ø)
lib/datadog/core/configuration/settings.rb 100.00% <ø> (ø)
...racing/contrib/active_model_serializers/patcher.rb 94.11% <0.00%> (ø)
lib/datadog/tracing/contrib/aws/patcher.rb 96.15% <0.00%> (ø)
...current_ruby/context_composite_executor_service.rb 95.65% <0.00%> (ø)
lib/datadog/tracing/contrib/integration.rb 100.00% <ø> (ø)
lib/datadog/tracing/contrib/qless/patcher.rb 95.00% <0.00%> (ø)
lib/datadog/tracing/contrib/qless/qless_job.rb 79.48% <0.00%> (ø)
lib/datadog/tracing/contrib/rake/patcher.rb 94.44% <0.00%> (ø)
lib/datadog/tracing/contrib/sequel/database.rb 97.05% <ø> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32fc71b...c7f5ae6. Read the comment docs.

@delner delner merged commit 3cbcea6 into master Mar 15, 2022
@delner delner deleted the refactor/tracer_integration_settings branch March 15, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Involves a breaking change dev/refactor Involves refactoring existing components integrations Involves tracing integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants