-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move integration settings into tracing namespace #1922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
integrations
Involves tracing integrations
breaking-change
Involves a breaking change
dev/refactor
Involves refactoring existing components
labels
Feb 28, 2022
delner
force-pushed
the
refactor/tracer_integration_settings
branch
from
March 1, 2022 15:16
f69f860
to
c7f5ae6
Compare
lloeki
reviewed
Mar 1, 2022
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
- Coverage 97.51% 97.50% -0.01%
==========================================
Files 997 997
Lines 48737 48747 +10
==========================================
+ Hits 47524 47532 +8
- Misses 1213 1215 +2
Continue to review full report at Codecov.
|
lloeki
reviewed
Mar 1, 2022
lloeki
reviewed
Mar 1, 2022
lloeki
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Involves a breaking change
dev/refactor
Involves refactoring existing components
integrations
Involves tracing integrations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For consistency, this pull request moves the
Contrib
extensions for settings fromDatadog.configuration
toDatadog.configuration.tracing
. This was done to ensure usage likeDatadog.configuration.tracing[:rails]
, which is unambiguous as to which feature it belongs.All integrations have been updated accordingly, and a change the the UpgradeGuide has been added to match.