Skip building profiling native extension when Ruby has been compiled without JIT #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without JIT The profiling native extension relies on the Ruby MJIT headers on 2.6+. But these headers are not available in Rubies that were compiled with JIT disabled. To avoid impacting these users (e.g. making them explicitly need to install with `DD_PROFILING_NO_EXTENSION=true`), let's automatically skip the extension when we detect that the JIT was disabled. In the future, we can explore using `debase-ruby_core_source` for these Ruby versions, if we still want to support these users. Fixes #1774
Codecov Report
@@ Coverage Diff @@
## master #1776 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 931 931
Lines 44910 44910
=======================================
+ Hits 44108 44109 +1
+ Misses 802 801 -1
Continue to review full report at Codecov.
|
marcotc
approved these changes
Nov 18, 2021
y-yagi
added a commit
to y-yagi/dd-trace-rb
that referenced
this pull request
Dec 13, 2021
DataDog#1776 is going to the 404 page.
y-yagi
added a commit
to y-yagi/dd-trace-rb
that referenced
this pull request
Dec 13, 2021
I'm not sure why, but DataDog#1776 is going to the 404 page now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiling native extension relies on the Ruby MJIT headers on 2.6+.
But these headers are not available in Rubies that were compiled with JIT disabled.
To avoid impacting these users (e.g. making them explicitly need to install with
DD_PROFILING_NO_EXTENSION=true), let's automatically skip the extension when we detect that the JIT was disabled.In the future, we can explore using
debase-ruby_core_sourcefor these Ruby versions, if we still want to support these users.Fixes #1774