Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistyped internal Pin on HTTP clients #1239

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Fix mistyped internal Pin on HTTP clients #1239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ddtrace/contrib/faraday/patcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def add_pin!
.new(
get_option(:service_name),
app: Ext::APP,
app_type: Datadog::Ext::AppTypes::WEB,
app_type: Datadog::Ext::HTTP::TYPE_OUTBOUND,
tracer: -> { get_option(:tracer) }
).onto(::Faraday)
end
Expand Down
4 changes: 2 additions & 2 deletions lib/ddtrace/contrib/http/instrumentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ def datadog_pin(config = Datadog.configuration[:http])
@datadog_pin ||= Datadog::Pin.new(
service,
app: Ext::APP,
app_type: Datadog::Ext::AppTypes::WEB,
app_type: Datadog::Ext::HTTP::TYPE_OUTBOUND,
tracer: -> { config[:tracer] }
)

Expand Down Expand Up @@ -146,7 +146,7 @@ def default_datadog_pin
@default_datadog_pin ||= Datadog::Pin.new(
service,
app: Ext::APP,
app_type: Datadog::Ext::AppTypes::WEB,
app_type: Datadog::Ext::HTTP::TYPE_OUTBOUND,
tracer: -> { config[:tracer] }
)
end
Expand Down
4 changes: 2 additions & 2 deletions lib/ddtrace/contrib/httprb/instrumentation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def datadog_pin(config = Datadog.configuration[:httprb])
Datadog::Pin.new(
service,
app: Ext::APP,
app_type: Datadog::Ext::AppTypes::WEB,
app_type: Datadog::Ext::HTTP::TYPE_OUTBOUND,
tracer: -> { config[:tracer] }
)
end
Expand All @@ -126,7 +126,7 @@ def default_datadog_pin
Datadog::Pin.new(
service,
app: Ext::APP,
app_type: Datadog::Ext::AppTypes::WEB,
app_type: Datadog::Ext::HTTP::TYPE_OUTBOUND,
tracer: -> { config[:tracer] }
)
end
Expand Down