Fix mistyped internal Pin on HTTP clients #1239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
Datadog::Pin
orDatadog::DeprecatedPin
created on theNet::HTTP
,Faraday
andhttp.rb
integrations were erroneously typed asweb
, while they should have been ofhttp
type.This actually is a non-issue for most users, as the span type eventually gets overwritten with
http
in all three integrations (Faraday example).Only users that directly manipulate the
Datadog::Pin
orDatadog::DeprecatedPin
associated with these three integrations are affected. The change fromweb
tohttp
will provide better classification of the spans by the backend, providing proper categorization in our front-end. There are no changes to the data contained in a tracer or to the metrics generated by traces.