Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistyped internal Pin on HTTP clients #1239

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 9, 2020

The default Datadog::Pin or Datadog::DeprecatedPin created on the Net::HTTP, Faraday and http.rb integrations were erroneously typed as web, while they should have been of http type.

This actually is a non-issue for most users, as the span type eventually gets overwritten with http in all three integrations (Faraday example).

Only users that directly manipulate the Datadog::Pin or Datadog::DeprecatedPin associated with these three integrations are affected. The change from web to http will provide better classification of the spans by the backend, providing proper categorization in our front-end. There are no changes to the data contained in a tracer or to the metrics generated by traces.

@marcotc marcotc requested a review from a team November 9, 2020 21:21
@marcotc marcotc self-assigned this Nov 9, 2020
@marcotc marcotc merged commit c8c7ee3 into master Nov 10, 2020
@marcotc marcotc deleted the fix/internal-pin-type branch November 10, 2020 16:00
@marcotc marcotc added this to the 0.43.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants