-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change profiling HTTP request runtime and type fields #1166
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2053145
Changed: Profiling HTTP request 'type' field to 'auto'
818296e
Added: #lang_engine and #lang_platform to Identity.
delner 183d2eb
Added: #runtime_engine and #runtime_platform to Flush.
delner 28893ef
Changed: Move profiling types field to constant.
delner be71575
Added: runtime_engine and runtime_platform tags to profiling HTTP req…
delner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
RSpec.describe Datadog::Profiling::Flush do | ||
describe '#new' do | ||
context 'given no arguments' do | ||
subject(:identifier) { described_class.new } | ||
|
||
it do | ||
is_expected.to have_attributes( | ||
start: nil, | ||
finish: nil, | ||
event_groups: nil, | ||
event_count: nil, | ||
runtime_id: Datadog::Runtime::Identity.id, | ||
service: Datadog.configuration.service, | ||
env: Datadog.configuration.env, | ||
version: Datadog.configuration.version, | ||
host: Datadog::Runtime::Socket.hostname, | ||
language: Datadog::Runtime::Identity.lang, | ||
runtime_engine: Datadog::Runtime::Identity.lang_engine, | ||
runtime_platform: Datadog::Runtime::Identity.lang_platform, | ||
runtime_version: Datadog::Runtime::Identity.lang_version, | ||
profiler_version: Datadog::Runtime::Identity.tracer_version | ||
) | ||
end | ||
end | ||
|
||
context 'given full arguments' do | ||
subject(:identifier) do | ||
described_class.new( | ||
start, | ||
finish, | ||
event_groups, | ||
event_count, | ||
runtime_id, | ||
service, | ||
env, | ||
version, | ||
host, | ||
language, | ||
runtime_engine, | ||
runtime_platform, | ||
runtime_version, | ||
profiler_version | ||
) | ||
end | ||
|
||
let(:start) { double('start') } | ||
let(:finish) { double('finish') } | ||
let(:event_groups) { double('event_groups') } | ||
let(:event_count) { double('event_count') } | ||
let(:runtime_id) { double('runtime_id') } | ||
let(:service) { double('service') } | ||
let(:env) { double('env') } | ||
let(:version) { double('version') } | ||
let(:host) { double('host') } | ||
let(:language) { double('language') } | ||
let(:runtime_engine) { double('runtime_engine') } | ||
let(:runtime_platform) { double('runtime_platform') } | ||
let(:runtime_version) { double('runtime_version') } | ||
let(:profiler_version) { double('profiler_version') } | ||
|
||
it do | ||
is_expected.to have_attributes( | ||
start: start, | ||
finish: finish, | ||
event_groups: event_groups, | ||
event_count: event_count, | ||
runtime_id: runtime_id, | ||
service: service, | ||
env: env, | ||
version: version, | ||
host: host, | ||
language: language, | ||
runtime_engine: runtime_engine, | ||
runtime_platform: runtime_platform, | ||
runtime_version: runtime_version, | ||
profiler_version: profiler_version | ||
) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to report these in the tracer payload as well. Nothing to do in this PR, just a reminder for our future selves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. In the tracer payload I think we send them as "interpreter" which is both terms combined.