Change profiling HTTP request runtime and type fields #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodav
force-pushed
the
fd/PROF-1952-set-type-to-auto
branch
from
8c814ec to
b412c0a
Compare
delner
force-pushed
the
fd/PROF-1952-set-type-to-auto
branch
from
b412c0a to
1049424
Compare
delner
changed the title
|
Made some updates to this:
These changes should address some needed things for the backend. |
delner
force-pushed
the
feature/profiling
branch
from
ce1b0fe to
8ae935d
Compare
delner
force-pushed
the
fd/PROF-1952-set-type-to-auto
branch
from
1049424 to
4509319
Compare
delner
force-pushed
the
feature/profiling
branch
from
459cecb to
98d996e
Compare
delner
force-pushed
the
fd/PROF-1952-set-type-to-auto
branch
from
4509319 to
be71575
Compare
marcotc
approved these changes
Sep 9, 2020
| @@ -27,7 +28,8 @@ def initialize(*args) | |||
| self.version = version || Datadog.configuration.version | |||
| self.host = host || Datadog::Runtime::Socket.hostname | |||
| self.language = language || Datadog::Runtime::Identity.lang | |||
| self.runtime = runtime || Datadog::Runtime::Identity.lang_interpreter | |||
| self.runtime_engine = runtime_engine || Datadog::Runtime::Identity.lang_engine | |||
| self.runtime_platform = runtime_platform || Datadog::Runtime::Identity.lang_platform | |||
There was a problem hiding this comment.
We might want to report these in the tracer payload as well. Nothing to do in this PR, just a reminder for our future selves.
There was a problem hiding this comment.
Good idea. In the tracer payload I think we send them as "interpreter" which is both terms combined.
ivoanjo
added a commit
that referenced
this pull request
Jan 5, 2022
This behavior was removed in #1166 but a test was left behind that no longer was relevant.
ivoanjo
added a commit
that referenced
this pull request
Jan 6, 2022
This behavior was removed in #1166 but a test was left behind that no longer was relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the profiling analyzer to process Ruby profiles. Today the quickest way is to set the
typefield toautowhile waiting for some heavy refactoring into the analyzer.We allow ourself to do this change since the profiler is still in beta.