Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate env, service, and version from tags #1008

Merged
merged 3 commits into from
Apr 15, 2020
Merged

Populate env, service, and version from tags #1008

merged 3 commits into from
Apr 15, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 15, 2020

This pull request:

  • Populates configuration env, service, and version to be populated from tags, if no value is set but a corresponding tag is configured.
  • Omits correlation attributes that have blank values from correlation strings.
  • Adds dd.service as a correlation attribute.

@delner delner added bug Involves a bug core Involves Datadog core libraries community Was opened by a community member labels Apr 15, 2020
@delner delner added this to the 0.35.0 milestone Apr 15, 2020
@delner delner requested review from marcotc, brettlangdon and a team April 15, 2020 20:08
@delner delner self-assigned this Apr 15, 2020
brettlangdon
brettlangdon previously approved these changes Apr 15, 2020
View reviewed changes
lib/ddtrace/correlation.rb Outdated Show resolved Hide resolved
@delner delner force-pushed the fix/env_vars_from_tags branch from bc6f43e to aeb47e8 Compare April 15, 2020 20:35
marcotc
marcotc previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! I left a :nit: documentation suggestion, but it's an overall :shipit:.

docs/GettingStarted.md Outdated Show resolved Hide resolved
@delner delner mentioned this pull request Apr 15, 2020
Closed
brettlangdon
brettlangdon previously approved these changes Apr 15, 2020
View reviewed changes
@delner delner dismissed stale reviews from brettlangdon and marcotc via 70863c4 April 15, 2020 20:47
@delner delner force-pushed the fix/env_vars_from_tags branch from aeb47e8 to 70863c4 Compare April 15, 2020 20:47
@delner delner merged commit f9db8f2 into master Apr 15, 2020
@delner delner deleted the fix/env_vars_from_tags branch April 15, 2020 21:02
@delner delner mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettlangdon brettlangdon brettlangdon approved these changes

@marcotc marcotc marcotc approved these changes

Assignees

@delner delner

Labels
bug Involves a bug community Was opened by a community member core Involves Datadog core libraries
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
3 participants
@delner @marcotc @brettlangdon