Extract runtime metrics worker from Writer #1004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
marcotc
reviewed
Apr 14, 2020
| logger = settings.logger.instance || Datadog::Logger.new(STDOUT) | ||
| logger.level = settings.diagnostics.debug ? ::Logger::DEBUG : settings.logger.level | ||
| def build_runtime_metrics_worker(settings) | ||
| # NOTE: Should we just ignore building the worker if its not enabled? |
There was a problem hiding this comment.
For the time being, because we still allow dynamic reconfiguration, I think always initializing it is ok.
There was a problem hiding this comment.
Okay, I'll remove this for now... we'll consider optimizations like this later.
There was a problem hiding this comment.
I think the comment is actually helpful for future work towards true immutable components: it guides us to where we need to make changes.
I think we should keep it.
I think I saw the comment as a "request for comment" and I was just chiming in on what I think about it.
There was a problem hiding this comment.
Yeah, that is kind of the spirit of writing it, so this is good.
delner
force-pushed
the
refactor/extract_runtime_metrics_worker
branch
from
d4178f8 to
10592ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a continuation of the shift towards immutable components, this pull request extracts the runtime metrics worker out of the writer. Previously this has been nested in
tracer.writer.runtime_metrics, and has piggybacked on the writer's thread to do runtime metrics work.To do this:
Datadog::Writer.runtime_metricsis introduced as an attribute ofComponents, which is aDatadog::Workers::RuntimeMetrics.