Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionView::render swallows given block #359

Closed
dorner opened this issue Feb 28, 2018 · 2 comments
Closed

ActionView::render swallows given block #359

dorner opened this issue Feb 28, 2018 · 2 comments
Assignees
@delner
Labels
bug Involves a bug community Was opened by a community member

Comments

@dorner
Copy link
Contributor

dorner commented Feb 28, 2018

render can take a block implementation inside ActionView. DataDog swallows this block rather than passing it onto the underlying method, which can cause crashes when it tries to render the block since other options like :file and :partial are not given.

Testing using Rails 3.0.
@delner delner self-assigned this Feb 28, 2018
@delner delner added bug Involves a bug community Was opened by a community member labels Feb 28, 2018
@delner
Copy link
Contributor

delner commented Feb 28, 2018

Related PR #360

@delner
Copy link
Contributor

delner commented Mar 6, 2018

Resolved with #360

@delner delner closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delner delner

Labels
bug Involves a bug community Was opened by a community member
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dorner @delner