Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active_record integration breaks without sinatra #328

Closed
hawknewton opened this issue Jan 26, 2018 · 3 comments
Closed

active_record integration breaks without sinatra #328

hawknewton opened this issue Jan 26, 2018 · 3 comments
Labels
bug Involves a bug
Milestone

Comments

@hawknewton
Copy link

Here's my config:

Datadog.configure do |config|
  config.use :active_record, service_name: 'random-service'
  config.use :grape, service_name: 'random-service'
end

And here's what I get:

E, [2018-01-25T21:10:34.973666 #6271] ERROR -- ddtrace: [ddtrace] (/usr/local/var/rbenv/versions/2.4.2/lib/ruby/gems/2.4.0/gems/ddtrace-0.11.0/lib/ddtrace/contrib/active_record/patcher.rb:100:in `rescue in sql') 'sinatra' is not a valid integration.

I'm sure it has something to do with this. To be fair I haven't tried it with sinatra, but I'd wager it'll work.

@palazzem
Copy link
Contributor

@hawknewton pretty sure it could be related. Thank you very much for reporting the issue, we're working on it immediately.

@palazzem
Copy link
Contributor

@hawknewton PR has been submitted and reviewed! Once the CI is green, we'll merge the PR and it will be released with the next bugfix release (happening next Monday). Thanks for reporting this critical issue!

@palazzem
Copy link
Contributor

@hawknewton merged! it will be part of the next 0.11.1 release! thanks again (also for the review)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Involves a bug
Projects
None yet
Development

No branches or pull requests

2 participants