Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alias []= set_tag and possibly other convenient methods. #2075

Closed
ioquatix opened this issue Jun 10, 2022 · 0 comments · Fixed by #2076
Closed

Add alias []= set_tag and possibly other convenient methods. #2075

ioquatix opened this issue Jun 10, 2022 · 0 comments · Fixed by #2076
Assignees
@delner
Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one

Comments

@ioquatix
Copy link
Contributor

ioquatix commented Jun 10, 2022 •
edited
Loading

It would be convenient to support span[key] = value as an alias for setting a tag.

dd-trace-rb/lib/datadog/tracing/metadata/tagging.rb

Line 12 in 0646d7d

module Tagging

ioquatix added a commit to ioquatix/dd-trace-rb that referenced this issue Jun 10, 2022
@ioquatix
Add convenient interface for getting and setting tags using [] and …
9482f24 
…`[]=` respectively.

Fixes DataDog#2075.
This was referenced Jun 10, 2022
Merged
Merged
@delner delner added feature-request A request for a new feature or change to an existing one community Was opened by a community member labels Jun 10, 2022
@delner delner self-assigned this Jun 10, 2022
marcotc pushed a commit that referenced this issue Jun 30, 2022
@ioquatix @marcotc
Add convenient interface for getting and setting tags using [] and …
91010c6 
…`[]=` respectively.

Fixes #2075.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@delner delner

Labels
community Was opened by a community member feature-request A request for a new feature or change to an existing one
Projects
None yet
Milestone
No milestone
2 participants
@ioquatix @delner