Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong distributed headers injection env var is used #1226

Closed
jumbosushi opened this issue Oct 30, 2020 · 2 comments
Closed

Wrong distributed headers injection env var is used #1226

jumbosushi opened this issue Oct 30, 2020 · 2 comments
Milestone

Comments

@jumbosushi
Copy link

jumbosushi commented Oct 30, 2020

I'm finding two permutations of DD_PROPAGATION_STYLE_INJECT string being used throughout the documentation and the code:
A. DD_PROPAGATION_STYLE_INJECT
B. DD_PROPAGATION_INJECT_STYLE

From the Ruby documentation, I expected this library to parse the environment variable in permutation A. However, this library uses permutation B.

Go documentation mentions the use of permutation A which is consistent with the dd-trace-go source code

What do you think about updating the code to use permutation A (that'll be consistent with the documentation and other languages)?

extraction env var uses the wrong ordering as well.

@jumbosushi jumbosushi changed the title Ordering of DD_PROPAGATION_STYLE_* env var Wrong distributed headers injection env var is used Oct 30, 2020
@marcotc
Copy link
Member

marcotc commented Oct 30, 2020

👋, thank you reporting this issue.

Our documentation is definitely mismatched with our implementation. I believe the correct course of action is to move Ruby to move to DD_PROPAGATION_STYLE_INJECT instead.

I'll double check with our team to find out what the desired environment variable name is.

@marcotc
Copy link
Member

marcotc commented Nov 18, 2020

👋 @jumbosushi, we've shipped a fix for this issue in 0.43.0. I'm closing this issue as done.

Please let us now if you still have any feedback on it.

@marcotc marcotc closed this as completed Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants