Skip to content

Commit

Permalink
[PROF-11007] Upgrade to libdatadog 14.3.1
Browse files Browse the repository at this point in the history
**What does this PR do?**

This PR upgrades the datadog gem to use libdatadog 14.3.1.

There were no needed API changes, it's a drop-in upgrade.

**Motivation:**

Staying on the latest libdatadog enables us to pick up the latest
improvements and also makes it easier to develop new features that need
libdatadog changes.

**Additional Notes:**

As usual, I'm opening this PR as a draft as libdatadog 14.3.1 is not yet
available on rubygems.org, and I'll come back to re-trigger CI and mark
this as non-draft once it is.

**How to test the change?**

Our existing test coverage includes libdatadog testing, so a green CI is good here :)
  • Loading branch information
ivoanjo committed Dec 5, 2024
1 parent f354358 commit 561bfb4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion datadog.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ Gem::Specification.new do |spec|

# When updating the version here, please also update the version in `libdatadog_extconf_helpers.rb`
# (and yes we have a test for it)
spec.add_dependency 'libdatadog', '~> 14.1.0.1.0'
spec.add_dependency 'libdatadog', '~> 14.3.1.1.0'

spec.extensions = [
'ext/datadog_profiling_native_extension/extconf.rb',
Expand Down
2 changes: 1 addition & 1 deletion ext/libdatadog_extconf_helpers.rb
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module Datadog
module LibdatadogExtconfHelpers
# Used to make sure the correct gem version gets loaded, as extconf.rb does not get run with "bundle exec" and thus
# may see multiple libdatadog versions. See https://github.com/DataDog/dd-trace-rb/pull/2531 for the horror story.
LIBDATADOG_VERSION = '~> 14.1.0.1.0'
LIBDATADOG_VERSION = '~> 14.3.1.1.0'

# Used as an workaround for a limitation with how dynamic linking works in environments where the datadog gem and
# libdatadog are moved after the extension gets compiled.
Expand Down

0 comments on commit 561bfb4

Please sign in to comment.