Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardcode the latest version of node as 22.4 #4526

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jul 17, 2024

What does this PR do?

Hardcode the latest version of node as 22.4

Motivation

Node 22.5 seems to have a pretty nasty bug that fails a lot of our tests.

Copy link

github-actions bot commented Jul 17, 2024

Overall package size

Self size: 6.83 MB
Deduped: 58.32 MB
No deduping: 58.6 MB

Dependency sizes

name version self size total size
@datadog/native-appsec 8.0.1 15.59 MB 15.6 MB
@datadog/native-iast-taint-tracking 3.0.0 11.14 MB 11.15 MB
@datadog/pprof 5.3.0 9.85 MB 10.22 MB
protobufjs 7.2.5 2.77 MB 6.56 MB
@datadog/native-iast-rewriter 2.3.1 2.15 MB 2.24 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.8.0 1.21 MB 1.21 MB
import-in-the-middle 1.8.1 71.67 kB 741.34 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
pprof-format 2.1.0 111.69 kB 111.69 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
shell-quote 1.8.1 44.96 kB 44.96 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
tlhunter-sorted-set 0.1.0 24.94 kB 24.94 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.4 23.1 kB 23.1 kB
retry 0.13.1 18.85 kB 18.85 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jul 17, 2024

Benchmarks

Benchmark execution time: 2024-07-17 22:27:32

Comparing candidate commit 54fe15e in PR branch node-latest-action-22.4 with baseline commit 5a22a17 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 256 metrics, 10 unstable metrics.

@rochdev rochdev marked this pull request as ready for review July 17, 2024 22:27
@rochdev rochdev requested review from a team as code owners July 17, 2024 22:27
@Qard Qard merged commit 9cd08c6 into master Jul 18, 2024
171 checks passed
@Qard Qard deleted the node-latest-action-22.4 branch July 18, 2024 04:42
@watson
Copy link
Collaborator

watson commented Jul 19, 2024

Do we have a plan to remember to revert this once the bug is fixed in node core?

juan-fernandez pushed a commit that referenced this pull request Jul 22, 2024
* hardcode the latest version of node as 22.4

* hardcode additional plugins

* hardcode additional ci jobs

* fix cypress
juan-fernandez pushed a commit that referenced this pull request Jul 22, 2024
* hardcode the latest version of node as 22.4

* hardcode additional plugins

* hardcode additional ci jobs

* fix cypress
rochdev added a commit that referenced this pull request Jul 22, 2024
bengl pushed a commit that referenced this pull request Jul 22, 2024
juan-fernandez pushed a commit that referenced this pull request Jul 23, 2024
* hardcode the latest version of node as 22.4

* hardcode additional plugins

* hardcode additional ci jobs

* fix cypress
juan-fernandez pushed a commit that referenced this pull request Jul 23, 2024
* hardcode the latest version of node as 22.4

* hardcode additional plugins

* hardcode additional ci jobs

* fix cypress
wconti27 pushed a commit that referenced this pull request Jul 30, 2024
wconti27 pushed a commit that referenced this pull request Jul 31, 2024
wconti27 pushed a commit that referenced this pull request Jul 31, 2024
wconti27 pushed a commit that referenced this pull request Jul 31, 2024
juan-fernandez pushed a commit that referenced this pull request Aug 5, 2024
juan-fernandez pushed a commit that referenced this pull request Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants