why does our test suite suck so much

DataDog · Jul 10, 2024 · bbdd8a0 · bbdd8a0
1 parent ad39514
commit bbdd8a0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/packages/datadog-plugin-aws-sdk/test/sns.spec.js b/packages/datadog-plugin-aws-sdk/test/sns.spec.js
@@ -1,6 +1,9 @@
 /* eslint-disable max-len */
 'use strict'
 
+process.env.DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING = '$.MessageAttributes.foo,$.MessageAttributes.redacted.StringValue.foo'
+process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING = '$.MessageId,$.Attributes.DisplayName'
+
 const sinon = require('sinon')
 const semver = require('semver')
 const agent = require('../../dd-trace/test/plugins/agent')
@@ -86,9 +89,9 @@ describe('Sns', function () {
 
     describe('with payload tagging', () => {
       before(() => {
-        console.log('SET ENV VARS')
-        process.env.DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING = '$.MessageAttributes.foo,$.MessageAttributes.redacted.StringValue.foo'
-        process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING = '$.MessageId,$.Attributes.DisplayName'
+        // console.log('SET ENV VARS')
+        // process.env.DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING = '$.MessageAttributes.foo,$.MessageAttributes.redacted.StringValue.foo'
+        // process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING = '$.MessageId,$.Attributes.DisplayName'
         return agent.load('aws-sdk', {})
       })
 
@@ -115,11 +118,11 @@ describe('Sns', function () {
         return agent.close({ ritmReset: false, wipe: true })
       })
 
-      after(() => {
-        console.log('REMOVE ENV VARS')
-        delete process.env.DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING
-        delete process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING
-      })
+      // after(() => {
+      // console.log('REMOVE ENV VARS')
+      // delete process.env.DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING
+      // delete process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING
+      // })
 
       afterEach(() => {
         return agent.reload('aws-sdk')

diff --git a/packages/dd-trace/src/config.js b/packages/dd-trace/src/config.js
@@ -366,14 +366,14 @@ class Config {
         options.cloudPayloadTagging?.request, // array
         ''
       ))
+    console.log('DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING', DD_TRACE_CLOUD_REQUEST_PAYLOAD_TAGGING)
 
     const DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING = splitJSONPathRules(
       coalesce(
         process.env.DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING,
         options.cloudPayloadTagging?.response,
         ''
       ))
-      console.log('OPTIONS', options)
     console.log('DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING', DD_TRACE_CLOUD_RESPONSE_PAYLOAD_TAGGING)
 
     const DD_TRACE_CLOUD_PAYLOAD_TAGGING_MAX_DEPTH = coalesce(