Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dd.grpc.server.error.statuses system property not working in v1.44.1 (worked fine in v1.43.0) #8114

Open
socar-brownie opened this issue Dec 19, 2024 · 1 comment

Comments

@socar-brownie
Copy link

socar-brownie commented Dec 19, 2024

I have been using the dd.grpc.server.error.statuses system property to configure how gRPC server spans are marked as errored.
In version v1.43.0, this property worked as expected. However, after upgrading to v1.44.1, it no longer seems to take effect.

Is this a bug, or do I need to adjust some configuration values for the new version?

@socar-brownie socar-brownie changed the title dd.grpc.server.error.statuses system property not working in v1.44.1 (worked fine in v1.43.0) dd.grpc.server.error.statuses system property not working in v1.44.1 (worked fine in v1.43.0) Dec 19, 2024
@amarziali
Copy link
Collaborator

Hello, thanks for having opened This github issue. The changes in behaviour might be due to this PR. In particular that PR fixed a bug concerning manual error flag overrrides in grpc. In fact if the span was manually marked as errored, then the dd.grpc.server.error.statuses rule might have them changed.
The manual setting should always take precedence hence we used error priorities to avoid this from happening.
Are you doing any kind of manual tracing or manually setting error or tags to those grpc spans?
If not you should not be impacted. It would be useful to know more about the spans you're creating and how the code looks like. I can also suggest to reach the helpdesk and open a case asking to escalate that issue.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants